Use Localazy's langAliases for Indonesian language
#4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can remove the 'move all translations' stop in the download strings script.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4801 +/- ##
========================================
Coverage 80.43% 80.43%
========================================
Files 2143 2143
Lines 56769 56769
Branches 7120 7120
========================================
Hits 45660 45660
Misses 8672 8672
Partials 2437 2437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmarty
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Instead of manually moving all the
values-idtovalues-inin some post-processing, this instructs the CLI to already download them in the right folders.Motivation and context
This way we can remove the 'move all translations' step in the download strings script. I was looking at something else when I noticed this option for the Localazy CLI tool.
Tests
I tested this locally with
./tools/localazy/downloadStrings.sh --alland it worked as expected.Checklist